Why do bad things happen?

Context is the key here. The readers of James were facing poverty and an persecution.  He wasn’t talking about small everyday events like a flat tire or a the persecution of a long line at the drive thru for breakfast. He's not talking about our immediate emotional response to flat tire, or an illness, or the loss of a loved one.   He's talking about how we categorize that moment when assessing our life as a whole.